[Stoq-devel] Re: [POS-commit] r3989 - in stoqlib/trunk: stoqlib/lib

[Henrique Romano]

Johan Dahlin escreveu:
> Henrique Romano wrote:
>   
>> Johan Dahlin escreveu:
>>     
>>> +
>>> +from kiwi.component import implements
>>>   
>>>       
>> why not zope.interface? since it have been used in all stoqlib
>>     
>
> It's an abstaction of top of it, it'll be the same.
>
> There's no written standard, if you write a document I will.
>
>   
Cool -- so you can start updating imports, this will be good.

>>> +from kiwi.log import Logger
>>> +
>>> +from stoqlib.lib.interfaces import CookieError, ICookieFile
>>>   
>>>       
>> Exceptions must be in stoqlib.exceptions, not stoqlib.lib.interfaces
>>     
>
> Why?
> stoqlib.lib.exceptions is silly, it should be removed IMHO.
>
>   

why? stoqlib.lib.exceptions is good and should remains as it is.
It is cool when you known where you can to read about exceptions and add 
one if it is neeeded.

> There are exceptions outside of that one; eg stoqlib/domain/base.py
>   

thats a bug.

Henrique.