[Stoq-devel] [Bug 1988] - Suporte à fotografia no editor de produtos

[bugzilla-daemon at async.com.br]

http://bugs.async.com.br/show_bug.cgi?id=1988  


Johan Dahlin <jdahlin at async.com.br> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Attachment #3333|                            |review-
               Flag|                            |




--- Comment #11 from Johan Dahlin <jdahlin at async.com.br>  2006-07-21 15:39 BRT ---
(From update of attachment 3333)
>Index: data/glade/SellableEditor.glade

>+                        <property name="y_options">&amp;lt;flags 0 of type GtkAttachOptions&amp;gt;</property>

This is fixed in recent versions of gazpacho. Can you please redo this or just
run it through gazpacho -u ? (which just loads and saves the files)

>Index: stoqlib/gui/editors/sellable.py
                               "weighing"))
>+        # product image slave
>+        self.image_slave = ImageSlave()
>         BaseEditor.__init__(self, conn, model)

>+        self.attach_slave("product_image_holder", self.image_slave)

Is it not a method setup_slaves here where you should do that?

> 
>+    def on_image_slave__pixbuf_selected(self, image_slave, button):

Move this to the image slave, it's generic.

>+        file_patterns = ["*.jpg","*.png"]

Is it not possible to query gtk (gdk-pixbuf) for a list of supported formats?


>Index: stoqlib/gui/base/slaves.py

No reason to include this, do svn revert stoqlib/gui/base/slaves.py to avoid
including it in the diff

>Index: stoqlib/gui/slaves/image.py

>+## Author(s):   Evandro Vale Miquelito      <evandro at async.com.br>

Update name!

>+##
>+
>+""" Slave for image """

You need a better description here.