[Stoq-devel] Re: [POS-commit] r3989 - in stoqlib/trunk: stoqlib/lib

[Henrique Romano]

Johan Dahlin escreveu:
> +
> +from kiwi.component import implements
>   

why not zope.interface? since it have been used in all stoqlib

> +from kiwi.log import Logger
> +
> +from stoqlib.lib.interfaces import CookieError, ICookieFile
>   
Exceptions must be in stoqlib.exceptions, not stoqlib.lib.interfaces
> Added: stoqlib/trunk/stoqlib/lib/interfaces.py
> ==============================================================================
>
> +
> +""" Stoqlib Interfaces """
>   

We have also stoqlib.domain.interfaces and stoqlib.gui.interfaces.
Can you please improve this documentation?

> +
> +from kiwi.component import Interface
>   
Please, follow the stoqlib standard.

> +
> +class CookieError(Exception):
> +    pass
>   

move to stoqlib.exceptions

Henrique.