[Stoq-devel] Re: [POS-commit] r3989 - in stoqlib/trunk: stoqlib/lib

[Johan Dahlin]

>>>> +from kiwi.log import Logger
>>>> +
>>>> +from stoqlib.lib.interfaces import CookieError, ICookieFile
>>>>         
>>> Exceptions must be in stoqlib.exceptions, not stoqlib.lib.interfaces
>>>     
>>
>> Why?
>> stoqlib.lib.exceptions is silly, it should be removed IMHO.
>>
>>   
> 
> why? stoqlib.lib.exceptions is good and should remains as it is.
> It is cool when you known where you can to read about exceptions and add
> one if it is neeeded.

No, I exceptions should be defined close to where they are raised.
Look at Kiwi & Gazpacho for examples of this.

I put the exception in interfaces because I don't want to import anything
from the implementation in the callsite.

-- 
Johan Dahlin <jdahlin at async.com.br>
Async Open Source