[Stoq-devel] [Bug 2712] - Make current branch & current branch station utilities

bugzilla-daemon at async.com.br bugzilla-daemon at async.com.br
Mon Jul 31 10:45:52 BRT 2006


http://bugs.async.com.br/show_bug.cgi?id=2712  





--- Comment #6 from Henrique Romano <henrique at async.com.br>  2006-07-31 10:45 BRT ---
(In reply to comment #5)
> > > > >Index: stoqlib/stoqlib/lib/interfaces.py
> > > 
> > > > >+class ICurrentBranch(Interface):
> > > > >+    """
> > > > >+    This is a mainly a marker for the current branch.
> > > > >+    It's mainly used by get_current_branch()
> > > > >+    """
> > > > 
> > > > it is not supposed to be IBranch?
> > > 
> > > There is already another interface called IBranch, so it'd be confusing to have
> > > two with the same name.
> > > 
> > 
> > sure, make this interface a subclass then?
> 
> That'll add a dependency of stoqlib.domain.interfaces in
> stoqlib.lib.interfaces, which I rather avoided. I can add a comment explaining
> that utilities providing this interface are expected to implement IBranch, is
> that good enough?
> 

Not sure, you may want to test interface implementations in the future, and
then it will not works.. but right, thats ok to add a comment right now..

r=henrique


More information about the Stoq-devel mailing list